G-2170

🆓

Warning

Never overload variables.

Variable

Rule Details

Severity Level: Major
Quality Area: Maintainability
Fixing times: 5 mins
Local-medium
Database Support: OracleDB (v7.3.4 +)

Reason

The readability of your code will be higher when you do not overload variables.

Example

Non-Compliant Example

begin
   <<main>>
   declare
      co_main    constant user_objects.object_name%type := 'test_main';
      co_sub     constant user_objects.object_name%type := 'test_sub';
      co_sep     constant user_objects.object_name%type := ' - ';
      l_variable user_objects.object_name%type          := co_main;
   begin
      <<sub>>
      declare
         l_variable user_objects.object_name%type := co_sub;
      begin
         sys.dbms_output.put_line(l_variable
            || co_sep
            || main.l_variable);
      end sub;
   end main;
end;
/

Issues

Line	Column	Message
11	10	Overloaded variable l_variable.

Compliant Solution - ★★★★★

begin
   <<main>>
   declare
      co_main         constant user_objects.object_name%type := 'test_main';
      co_sub          constant user_objects.object_name%type := 'test_sub';
      co_sep          constant user_objects.object_name%type := ' - ';
      l_main_variable user_objects.object_name%type          := co_main;
   begin
      <<sub>>
      declare
         l_sub_variable user_objects.object_name%type := co_sub;
      begin
         sys.dbms_output.put_line(l_sub_variable
            || co_sep
            || l_main_variable);
      end sub;
   end main;
end;
/

Rule Details

Reason

Example

× Non-Compliant Example

✓ Compliant Solution - ★★★★★

References

Non-Compliant Example

Compliant Solution - ★★★★★