G-7120
🆓Warning
Always add the name of the program unit to its end keyword.
Reason
It's a good alternative for comments to indicate the end of program units, especially if they are lengthy or nested.
Example
Non-Compliant Example
create or replace package body employee_api is
function employee_by_id(in_employee_id in integer) -- NOSONAR G-7460: non-deterministic
return employees%rowtype is
co_employee_id constant employees.employee_id%type := in_employee_id;
r_employee employees%rowtype;
begin
select *
into r_employee
from employees
where employee_id = co_employee_id;
return r_employee;
exception
when no_data_found then
null;
when too_many_rows then
raise;
end;
end;
/Issues
| Line | Column | Message |
|---|---|---|
| 18 | 4 | Add label employee_by_id to indicate the end of the function. |
| 19 | 1 | Add label employee_api to indicate the end of the package body. |
Compliant Solution - ★★★★★
create or replace package body employee_api is
function employee_by_id(in_employee_id in integer) -- NOSONAR G-7460: non-deterministic
return employees%rowtype is
co_employee_id constant employees.employee_id%type := in_employee_id;
r_employee employees%rowtype;
begin
select *
into r_employee
from employees
where employee_id = co_employee_id;
return r_employee;
exception
when no_data_found then
null;
when too_many_rows then
raise;
end employee_by_id;
end employee_api;
/References
- same as Trivadis G-7120