G-4325

🆓

Warning

Never reuse labels in inner scope.

Rule Details

Severity Level: Major
Quality Area: Maintainability
Fixing times: 5 mins
Local-medium
Database Support: OracleDB (v7.3.4 +)

Reason

Reusing labels inside the scope of another label with the same name leads to confusion, less chance of understanding the code, and could lead to bugs (for example if using exit my_label exits at a different nesting level than expected.)

Example

Non-Compliant Example

<<my_label>>
declare
   co_min_value constant simple_integer := 1;
   co_max_value constant simple_integer := 8;
begin
   <<my_label>>
   for i in co_min_value..co_max_value
   loop
      sys.dbms_output.put_line(i);
   end loop my_label;
end my_label;
/

Issues

Line	Column	Message
6	4	Reusing label my_label in inner scopes.

Compliant Solution - ★★★★★

<<output_values>>
declare
   co_min_value constant simple_integer := 1;
   co_max_value constant simple_integer := 8;
begin
   <<process_values>>
   for i in co_min_value..co_max_value
   loop
      sys.dbms_output.put_line(i);
   end loop process_values;
end output_values;
/

References

same as Trivadis G-4325
same as plsql:NameReusedInInnerScope