G-4270
🆓Warning
Avoid comparing boolean values to boolean literals.
Reason
It is more readable to simply use the boolean value as a condition itself, rather than use a comparison condition comparing the boolean value to the literals true or false.
Example
Non-Compliant Example
declare
co_string constant types_up.text := '42';
l_is_valid boolean;
begin
l_is_valid := my_package.is_valid_number(co_string);
if l_is_valid = true then
my_package.convert_number(l_string);
end if;
end;
/Issues
| Line | Column | Message |
|---|---|---|
| 6 | 7 | Comparing boolean values to boolean literals. |
Compliant Solution - ★★★★★
declare
co_string constant types_up.text := '42';
l_is_valid boolean;
begin
l_is_valid := my_package.is_valid_number(co_string);
if l_is_valid then
my_package.convert_number(l_string);
end if;
end;
/References
- same as Trivadis G-4270
- same as plsqlopen:ComparisonWithBoolean